Skip to content

remove @alexandremattiioli from contributors as he is a committer now#8525

Merged
yadvr merged 1 commit intomainfrom
contributors
Feb 5, 2024
Merged

remove @alexandremattiioli from contributors as he is a committer now#8525
yadvr merged 1 commit intomainfrom
contributors

Conversation

@DaanHoogland
Copy link
Contributor

Description

This PR...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

not

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c3b77cb) 18.28% compared to head (ea668d5) 29.67%.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #8525       +/-   ##
=============================================
+ Coverage     18.28%   29.67%   +11.39%     
- Complexity    16826    32585    +15759     
=============================================
  Files          4848     5341      +493     
  Lines        324301   374973    +50672     
  Branches      45561    54546     +8985     
=============================================
+ Hits          59290   111268    +51978     
+ Misses       256437   248901     -7536     
- Partials       8574    14804     +6230     
Flag Coverage Δ
simulator-marvin-tests 23.17% <ø> (+4.88%) ⬆️
uitests 4.39% <ø> (?)
unit-tests 16.49% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DaanHoogland
Copy link
Contributor Author

@alexandremattioli, I wanted to add you as a reviewer but i can't yet. make sure you are in the apache organisation on github!

@DaanHoogland
Copy link
Contributor Author

ps, supposing you approve of this change

@yadvr yadvr merged commit d8b4be6 into main Feb 5, 2024
@yadvr yadvr deleted the contributors branch February 5, 2024 08:52
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Feb 7, 2024
@DaanHoogland DaanHoogland added this to the unplanned milestone Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants